Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: enable staticcheck and prealloc on nogo #35486

Merged
merged 9 commits into from
Jun 22, 2022
Merged

*: enable staticcheck and prealloc on nogo #35486

merged 9 commits into from
Jun 22, 2022

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Jun 17, 2022 •
edited
Loading

Signed-off-by: Weizhen Wang [email protected]

What problem does this PR solve?

Issue Number: ref #35345

Problem Summary:

What is changed and how it works?

  • enable staticcheck and prealloc on nogo
  • update bazel

we add the //nolint or //linter Analyze.Pass to skip the linter like golangcilinter.

Check List

Tests

  • Unit test

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 17, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • tisonkun
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed do-not-merge/needs-linked-issue labels Jun 17, 2022
@hawkingrei hawkingrei requested a review from a team as a code owner June 17, 2022 15:39
@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 17, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Jun 17, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/ccd7b6ac67dfa77be1aa973b0985ec625514cc39

@ti-chi-bot ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 17, 2022
@hawkingrei
Copy link
Member Author

/run-unit-test

1 similar comment
@hawkingrei
Copy link
Member Author

/run-unit-test

@hawkingrei hawkingrei changed the title *: enable staticcheck *: enable staticcheck on nogo Jun 18, 2022
@hawkingrei hawkingrei force-pushed the enable_staticcheck branch 3 times, most recently from 6c80f77 to 16ff4a5 Compare June 18, 2022 13:27
@hawkingrei
Copy link
Member Author

/run-check_dev_2

@hawkingrei hawkingrei changed the title *: enable staticcheck on nogo *: enable staticcheck and prealloc on nogo Jun 20, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 20, 2022
@hawkingrei
Copy link
Member Author

/run-unit-test

tangenta
tangenta reviewed Jun 21, 2022
View reviewed changes
parser/model/model.go Outdated Show resolved Hide resolved
tangenta
tangenta reviewed Jun 21, 2022
View reviewed changes
parser/model/model.go Outdated Show resolved Hide resolved
tangenta
tangenta reviewed Jun 21, 2022
View reviewed changes
go.sum Show resolved Hide resolved
@hawkingrei hawkingrei requested review from tisonkun and removed request for a team June 22, 2022 01:44
tangenta
tangenta reviewed Jun 22, 2022
View reviewed changes
go.mod Show resolved Hide resolved
@tangenta
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 6fc21e46c29aa730a0550b284d51ca0bfb2f623c

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 22, 2022
@tangenta
Copy link
Contributor

/hold

@ti-chi-bot ti-chi-bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed status/can-merge Indicates a PR has been approved by a committer. labels Jun 22, 2022
@hawkingrei hawkingrei force-pushed the enable_staticcheck branch 3 times, most recently from 1ea6492 to 6e72812 Compare June 22, 2022 09:56
hawkingrei and others added 7 commits June 22, 2022 19:58
@hawkingrei
*: enable staticcheck
5c98a9b 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei @tangenta
Update parser/model/model.go
eacb3af 
Co-authored-by: tangenta <[email protected]>
@hawkingrei @tangenta
Update parser/model/model.go
7d4b4b7 
Co-authored-by: tangenta <[email protected]>
@hawkingrei
skip cgo for third party code
89d2289 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
refactor skipAnalyzer
8b736e7 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
refactor skipAnalyzer
edb6ba2 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
refactor skipAnalyzer
105f68a 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
Copy link
Member Author

/unhold

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 22, 2022
@hawkingrei
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: ccd7b6a

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 22, 2022
@ti-chi-bot ti-chi-bot merged commit d4dc6b5 into pingcap:master Jun 22, 2022
@hawkingrei hawkingrei deleted the enable_staticcheck branch June 22, 2022 14:02
@sre-bot
Copy link
Contributor

sre-bot commented Jun 22, 2022

TiDB MergeCI notify

✅ Well Done! New fixed [1] after this pr merged.

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/common-test ✅ all 12 tests passed 8 min 49 sec Fixed
idc-jenkins-ci/integration-cdc-test 🟢 all 35 tests passed 24 min Existing passed
idc-jenkins-ci-tidb/integration-common-test 🟢 all 11 tests passed 14 min Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 7 min 8 sec Existing passed
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 6 min 57 sec Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 6 min 29 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 5 min 15 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 3 min 17 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 3 min 8 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

@tangenta tangenta mentioned this pull request Jun 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tangenta tangenta tangenta left review comments

@tisonkun tisonkun tisonkun approved these changes

@xhebox xhebox xhebox approved these changes

@Defined2014 Defined2014 Awaiting requested review from Defined2014

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@hawkingrei @ti-chi-bot @sre-bot @tangenta @xhebox @tisonkun